-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate google-hosted kubernetes-build jobs #20964
Deprecate google-hosted kubernetes-build jobs #20964
Conversation
Now that all release-blocking jobs use artifacts stored in community-owned gs://k8s-release-dev, it's time to call the jobs that produce those artifacts release-blocking, and demote the jobs that write to gs://kubernetes-release-dev as release-informing. Deprecate jobs that write to gs://kuebrnetes-release-dev by: - appending deprecated to their job name and testgrid tab name - moving from release-blocking to release-informing Promote jobs that write to gs://k8s-release-dev by: - removing canary from their job name and testgrid tab name - moving from release-informing to release-blocking - removing from sig-testing-canaries This is a "breaking" change that will split job history across the rename boundary since tools like testgrid and kettle don't understand the concept of job renames
FYI @kubernetes/release-engineering @kubernetes/ci-signal @kubernetes/release-team-leads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very happy to see this change, thanks @spiffxp! My one concern here is that there are still some critical components (such as dl.k8s.io) that utilize the builds pushed to the old infra. Do we feel good about making this change before all consumers have moved over?
For SIG Release and associated subprojects:
Discussed and approved at today's SIG Release meeting. Two things to note:
Will leave @hasheddan to lifting the hold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
FWIW I took a quick look at what builds are present where: https://gist.github.com/spiffxp/9a339a93ae889d1378e6f2259a733895 The main point, I think:
It's not perfect, but looking at the actual builds that are missing, it's pretty good. Mostly flakes in both directions.
Exactly. I would like to switch dl.k8s.io/ci to point to k8s-release-dev at some point, but not until we have a better handle on ensuring build parity between the buckets (maybe using STS to sync, etc.) |
Part of #18549 (more specifically part of #19483)
Now that all release-blocking jobs use artifacts stored in community-owned
gs://k8s-release-dev
(ref: #20885), it's time to call the jobs that produce those artifacts release-blocking, and demote the jobs that write togs://kubernetes-release-dev
as release-informing.Deprecate jobs that write to
gs://kuebrnetes-release-dev
by:Promote jobs that write to
gs://k8s-release-dev
by:/hold
This is a "breaking" change that will split job history across the rename boundary since tools like testgrid and kettle don't understand the concept of job renames.
Would like consensus from SIG Release subprojects