Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MULTIZONE CI jobs #21777

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

dims
Copy link
Member

@dims dims commented Apr 13, 2021

Drops CI jobs mentioned in #21655

Signed-off-by: Davanum Srinivas davanum@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2021
@SergeyKanzhelev
Copy link
Member

/assign

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Apr 14, 2021
@dchen1107
Copy link
Member

I remembered the test was introduced initially as a regression tests, but I couldn't trace down the details. cc/ @BenTheElder
@MrHohn to see if they know more on this.

On another hand since the CI jobs failed for a long time without much attention, I am totally ok to remove it from OSS dashboard.

@dchen1107
Copy link
Member

Quickly sync up with @MrHohn. The test was added to capture issues (such as misconfigured LB, etc.) when running cluster in multiple zones initially. But we all agreed that the CI is still valid for OSS K8s. Meanwhile, the initial test cases were migrated to use internal CIs already.

@MrHohn
Copy link
Member

MrHohn commented Apr 14, 2021

I remembered the test was introduced initially as a regression tests, but I couldn't trace down the details. cc/ @BenTheElder
@MrHohn to see if they know more on this.

+1, the ingress-gce one was added to cover a regression when cluster runs on multiple zones. I believe we have internal CIs that cover the same cases already, so I'm fine with removing this CI.

@dchen1107
Copy link
Member

/lgtm
/approve

Thanks for cleaning up this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2021
@SergeyKanzhelev
Copy link
Member

/retest

@BenTheElder
Copy link
Member

2021/04/14 20:06:06 FAIL: could not write config: 1 error occurred:

  • could not find the referenced (TestGroup) ci-kubernetes-e2e-gce-multizone

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/testgrid and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Apr 14, 2021

@BenTheElder fixed now.

@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5bf4d67 into kubernetes:master Apr 14, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Apr 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gce-misc.yaml using file ``
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml
  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Drops CI jobs mentioned in #21655

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants