Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: fix kubernetes deprecated build jobs #22864

Merged
merged 1 commit into from
Jul 12, 2021
Merged

config/jobs: fix kubernetes deprecated build jobs #22864

merged 1 commit into from
Jul 12, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 12, 2021

The --release parameter was being picked up bootstrap.py instead of
the scenario it was invoking.

This should resolve kubernetes/kubernetes#103647 but I'm not using the fixes keyword so we can close it after we've seen successful job runs

This fixes a bug introduced in #22840, specifically in cbd67f4

@spiffxp
config/jobs: fix kubernetes deprecated build jobs
7a1d46b 
The `--release` parameter was being picked up bootstrap.py instead of
the scenario it was invoking.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 12, 2021
This was referenced Jul 12, 2021
Closed
Merged
@ameukam
Copy link
Member

ameukam commented Jul 12, 2021

/lgtm
/hold
Removed the hold if needed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 12, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 82caf5c into kubernetes:master Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key 1.20.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.20.yaml
  • key 1.21.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.21.yaml

In response to this:

The --release parameter was being picked up bootstrap.py instead of
the scenario it was invoking.

This should resolve kubernetes/kubernetes#103647 but I'm not using the fixes keyword so we can close it after we've seen successful job runs

This fixes a bug introduced in #22840, specifically in cbd67f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the fix-deprecated-build-jobs branch July 12, 2021 22:02
@spiffxp
Copy link
Member Author

spiffxp commented Jul 12, 2021

ref: kubernetes/k8s.io#2318

@justaugustus
Copy link
Member

Retroactive LGTM!
Thanks Aaron!

@spiffxp spiffxp mentioned this pull request Jul 15, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco Awaiting requested review from puerco

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

failing jobs: ci-kubernetes-build-deprecated (and release-branch variants)
4 participants
@spiffxp @k8s-ci-robot @ameukam @justaugustus