Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add presubmit jobs for controller-runtime release-0.9 branch #22956

Merged
merged 1 commit into from
Jul 20, 2021
Merged

add presubmit jobs for controller-runtime release-0.9 branch #22956

merged 1 commit into from
Jul 20, 2021

Conversation

sbueringer
Copy link
Member

Almost a copy of the once for the default branch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2021
@sbueringer
Copy link
Member Author

/assign @vincepri

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2021
@sbueringer sbueringer mentioned this pull request Jul 20, 2021
Merged
vincepri
vincepri approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit c0c1a41 into kubernetes:master Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key controller-runtime-presubmits-release-0.9.yaml using file config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-presubmits-release-0.9.yaml

In response to this:

Almost a copy of the once for the default branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-add-controller-runtime-presubmit-jobs branch July 20, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbueringer @k8s-ci-robot @vincepri