Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go1.17] Update kubernetes/kubernetes jobs to Golang 1.17 #23358

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 24, 2021

To merge kubernetes/kubernetes#103692, we need to cut kubernetes/kubernetes over to using Golang 1.17.

This PR only touches presubmits/periodics targeting kubernetes/kubernetes; there are lots of jobs outside of that repo that use kubekins-e2e/krte, so we're carefully trying to not cause churn on other repos.

Continuation of #23354.
go1.17 tracking: kubernetes/release#2169

  • [go1.17] Use go1.17 for kubernetes/kubernetes kind presubmits
    Image ref: gcr.io/k8s-testimages/krte:v20210824-2dc36d0-master
  • [go1.17] Use go1.17 for kubernetes/kubernetes kubekins-e2e jobs
    Image ref: gcr.io/k8s-testimages/kubekins-e2e:v20210824-2dc36d0-master

Signed-off-by: Stephen Augustus foo@auggie.dev

/hold for comms to k-dev https://groups.google.com/g/kubernetes-dev/c/5kiB72M8518
/priority critical-urgent
/assign @liggitt @saschagrunert @puerco @cpanato @jeremyrickard
cc: @kubernetes/sig-release @kubernetes/sig-instrumentation-approvers @kubernetes/sig-network-pr-reviews @kubernetes/sig-node-pr-reviews @kubernetes/sig-scalability @kubernetes/sig-testing

Image ref: gcr.io/k8s-testimages/krte:v20210824-2dc36d0-master

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Image ref: gcr.io/k8s-testimages/kubekins-e2e:v20210824-2dc36d0-master

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 24, 2021
@justaugustus
Copy link
Member Author

For config/:
/assign @cblecker @dims @spiffxp @chases2 @wojtek-t

@cadmuxe
Copy link
Member

cadmuxe commented Aug 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2021
@justaugustus
Copy link
Member Author

Email sent to k-dev: https://groups.google.com/g/kubernetes-dev/c/5kiB72M8518
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@dims
Copy link
Member

dims commented Aug 24, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit f68c0d0 into kubernetes:master Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key verify-govet-levee.yaml using file config/jobs/kubernetes/sig-instrumentation/verify-govet-levee.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key sig-storage-gce-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml
  • key dependencies.yaml using file config/jobs/kubernetes/sig-testing/dependencies.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key kubernetes-kind-presubmits.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml
  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml
  • key typecheck.yaml using file config/jobs/kubernetes/sig-testing/typecheck.yaml
  • key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

To merge kubernetes/kubernetes#103692, we need to cut kubernetes/kubernetes over to using Golang 1.17.

This PR only touches presubmits/periodics targeting kubernetes/kubernetes; there are lots of jobs outside of that repo that use kubekins-e2e/krte, so we're carefully trying to not cause churn on other repos.

Continuation of #23354.
go1.17 tracking: kubernetes/release#2169

  • [go1.17] Use go1.17 for kubernetes/kubernetes kind presubmits
    Image ref: gcr.io/k8s-testimages/krte:v20210824-2dc36d0-master
  • [go1.17] Use go1.17 for kubernetes/kubernetes kubekins-e2e jobs
    Image ref: gcr.io/k8s-testimages/kubekins-e2e:v20210824-2dc36d0-master

Signed-off-by: Stephen Augustus foo@auggie.dev

/hold for comms to k-dev https://groups.google.com/g/kubernetes-dev/c/5kiB72M8518
/priority critical-urgent
/assign @liggitt @saschagrunert @puerco @cpanato @jeremyrickard
cc: @kubernetes/sig-release @kubernetes/sig-instrumentation-approvers @kubernetes/sig-network-pr-reviews @kubernetes/sig-node-pr-reviews @kubernetes/sig-scalability @kubernetes/sig-testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet