Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branch protection for gh-pages in secrets-store-csi-driver #23384

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 27, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

The gh-pages branch is used for hosting helm charts: kubernetes-sigs/secrets-store-csi-driver#693. The github action's user can't sign CLA. So removing the branch protection for that branch.

The gh-pages branch will only be used for hosting helm charts.

/cc @tam7t

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from tam7t August 27, 2021 00:41
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 27, 2021
@aramase
Copy link
Member Author

aramase commented Aug 27, 2021

/assign @chases2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, chases2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@tam7t
Copy link
Contributor

tam7t commented Aug 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 2fbfb34 into kubernetes:master Aug 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 27, 2021
@aramase aramase deleted the skip-branch-protection-csi branch August 27, 2021 19:01
@k8s-ci-robot
Copy link
Contributor

@aramase: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

The gh-pages branch is used for hosting helm charts: kubernetes-sigs/secrets-store-csi-driver#693. The github action's user can't sign CLA. So removing the branch protection for that branch.

The gh-pages branch will only be used for hosting helm charts.

/cc @tam7t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants