Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: shrink and begin migrating away from node-e2e boskos pool #23777

Merged
merged 2 commits into from
Sep 27, 2021
Merged

config: shrink and begin migrating away from node-e2e boskos pool #23777

merged 2 commits into from
Sep 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 27, 2021 •
edited
Loading

Related:

Apparently doing the project addition and removal in a single PR wasn't enough to cause boskos to grow the node-e2e pool, so undoing that change to reflect reality

Also, there is nothing special about the projects in the node-e2e pool, so let's stop using it, and begin to migrate jobs over to the main gce-project pool

I chose an arbitrary group of presubmits first, since I suspect presubmits are the main reason the pool gets exhausted occasionally

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 27, 2021
@spiffxp spiffxp mentioned this pull request Sep 27, 2021
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Sep 27, 2021

/cc @SergeyKanzhelev @mmiranda96

SergeyKanzhelev
SergeyKanzhelev approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transitioning presubmits sounds great. I don't have context on this file changes: config/prow/cluster/boskos-resources.yaml

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@ehashman
Copy link
Member

ack 👍

@mmiranda96
Copy link
Contributor

I don't have context on the changes on boskos-resources.yaml. Besides that, it looks good.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmiranda96, SergeyKanzhelev, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b08442 into kubernetes:master Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Related:

Apparently doing the project addition and removal in a single PR wasn't enough to cause boskos to grow the node-e2e pool, so undoing that change to reflect reality

Also, there is nothing special about the projects in the node-e2e pool, so let's stop using it, and begin to migrate jobs over to the main gce-project pool

I chose an arbitrary group of presubmits first, since I suspect presubmits are the main reason the pool gets exhausted occasionally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the shrink-node-e2e-pool branch September 27, 2021 20:54
@adisky adisky mentioned this pull request Nov 17, 2021
Merged
@bobbypage bobbypage mentioned this pull request Jan 19, 2023
Merged
sairameshv added a commit to sairameshv/test-infra that referenced this pull request Jan 25, 2023
@sairameshv
Fix evented_pleg ci job to get away from `--gcp-project-type=node-e2e…
62de85f 
…-project`

From the references of the following merged PRs, the above parameter may not be required
to run the evented-pleg feature enabled node-e2e ci job.
Ref:
  1. kubernetes#28458
  2. kubernetes#23777

Signed-off-by: Sai Ramesh Vanka svanka@redhat.com
@sairameshv sairameshv mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@MHBauer MHBauer Awaiting requested review from MHBauer

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@mmiranda96 mmiranda96 Awaiting requested review from mmiranda96

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@spiffxp @ehashman @mmiranda96 @k8s-ci-robot @SergeyKanzhelev