Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/jobs: run no-stage on k8s-infra, drop extract #24238

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Nov 4, 2021

Related:

It's unclear to me why this job isn't working on the default build cluster due to a lack of docker. That's the only difference I can see vs. the normal job, so let's try reconciling that.

Also drop the --extract=local flag, because my read of the bash deployer is it should work with what's been built locally

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Nov 4, 2021

/cc @BenTheElder @amwat

@amwat
Copy link
Contributor

amwat commented Nov 4, 2021

Docker errors during build mean mostly likely related to DIND.

I think it needs

securityContext:
  privileged: true

for DIND

also yeah good point on removing extract altogether if it's not needed.
That should fix extract relying on --stage

@BenTheElder
Copy link
Member

I have a hazy memory of extract being necessary but .. so long ago ...

let's try it
/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
let's try it

@spiffxp
Copy link
Member Author

spiffxp commented Nov 17, 2021

@amwat

Docker errors during build mean mostly likely related to DIND.

I think it needs

securityContext:
  privileged: true

Good catch, that absolutely sounds like the issue. Updated the PR. Will run it on k8s-infra anyway just for extra parity

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Specifically:

- run on k8s-infra
- add securityContext to match pull-kubernetes-e2e-gce
- drop extract

Going to see if running directly with the results of --build=quick is
sufficient for e2e tests
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Nov 17, 2021

rebase fail, removed the dupe no-stage job definition

@BenTheElder
Copy link
Member

/lgtm

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 59fe492 into kubernetes:master Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

Related:

It's unclear to me why this job isn't working on the default build cluster due to a lack of docker. That's the only difference I can see vs. the normal job, so let's try reconciling that.

Also drop the --extract=local flag, because my read of the bash deployer is it should work with what's been built locally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants