-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/jobs: run no-stage on k8s-infra, drop extract #24238
Conversation
/cc @BenTheElder @amwat |
Docker errors during build mean mostly likely related to DIND. I think it needs
for DIND also yeah good point on removing extract altogether if it's not needed. |
I have a hazy memory of extract being necessary but .. so long ago ... let's try it |
ec176ac
to
7f49446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
let's try it
Good catch, that absolutely sounds like the issue. Updated the PR. Will run it on k8s-infra anyway just for extra parity |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Specifically: - run on k8s-infra - add securityContext to match pull-kubernetes-e2e-gce - drop extract Going to see if running directly with the results of --build=quick is sufficient for e2e tests
7f49446
to
7aaef8c
Compare
rebase fail, removed the dupe no-stage job definition |
/lgtm |
/hold cancel |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related:
It's unclear to me why this job isn't working on the default build cluster due to a lack of docker. That's the only difference I can see vs. the normal job, so let's try reconciling that.
Also drop the --extract=local flag, because my read of the bash deployer is it should work with what's been built locally