Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.18] kubekins/krte: Build go-canary variant using go1.18beta1 #24704

Merged
merged 1 commit into from
Dec 17, 2021
Merged

[go1.18] kubekins/krte: Build go-canary variant using go1.18beta1 #24704

merged 1 commit into from
Dec 17, 2021

Conversation

justaugustus
Copy link
Member

Part of kubernetes/release#2307.
For Golang pre-releases, the go-canary variant needs to be built ahead of the master variant to enable testing go canary presubmits for kubernetes/kubernetes#107105.

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @cpanato @saschagrunert @puerco
/cc @kubernetes/release-engineering

@justaugustus
kubekins/krte: Build go-canary variant using go1.18beta1
bd48ebc 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 17, 2021
@justaugustus justaugustus mentioned this pull request Dec 17, 2021
Merged
cpanato
cpanato approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus mentioned this pull request Dec 17, 2021
Closed
45 tasks
@k8s-ci-robot k8s-ci-robot merged commit ea95cec into kubernetes:master Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @cpanato @saschagrunert @puerco