klog flag deprecation #27305
Merged
klog flag deprecation #27305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the script is unused (?) because the current ./maintenance/migratestatus command doesn't support the flag.
It has been the default in klog for a long time and will be removed soon. -vmodule continues to be supported. The way it is used here seems unnecessarily complex, but perhaps there was a reason for it (like not conflicting with -v), so that part is kept.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/testing
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As describe in https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components, several klog flags will soon be removed from Kubernetes commands, in particular in the e2e test suites invoked by kubetest.
Right now that triggers a deprecation warning, for example in https://storage.googleapis.com/kubernetes-jenkins/logs/ci-crio-cgroupv1-node-e2e-conformance/1564520501156515840/build-log.txt