-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e-kubeadm release-1.6 job. #2765
Conversation
add it to the unit-test? |
Good call. New test added. |
Or is there something we can cherry-pick into 1.6 to make it upload to the right place? |
I thought about it, but with the already-murky situation with the 1.6.3 regression, I didn't want to push for cherry-picking even more into the 1.6 branch. I'll let @ixdy chime in, since he was the proponent of moving the |
sgtm, he'll be back Friday :-) |
Recent changes to kubernetes/master moved where bazel .deb files get pushed. The kubernetes_e2e.py scenario was updated to accommodate this change, but the kubernetes/release-1.6 branch still pushes these .debs to the old location. Since we only support ci/periodic jobs for release-1.6, and we expect to use the new location from now on, consider this a special case for now and we can remove this code when we no longer support the 1.6.x series.
Oh, Friday might be on the late side, since these |
Also the bazel failure this PR just started hitting ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@k8s-bot bazel test this |
Recent changes to kubernetes/master moved where bazel
.deb
files get pushed. Thekubernetes_e2e.py
scenario was updated to accommodate this change, but the kubernetes/release-1.6 branch still pushes these.debs
to the old location. Since we only support ci/periodic jobs for release-1.6, and we expect to use the new location from now on, consider this a special case for now and we can remove this code when we no longer support the 1.6.x series.