Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kueue E2E Tests #27868

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Kueue E2E Tests #27868

merged 1 commit into from
Nov 22, 2022

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Nov 2, 2022

PR kubernetes-sigs/kueue#421 adds e2e tests to Kueue and we want to add a e2e test in the testgrid.

I think we should merge once the above PR is merged.

Partial kubernetes-sigs/kueue#61

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kannon92!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kannon92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2022
This was referenced Nov 2, 2022
Merged
Closed
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2022
alculquicondor
alculquicondor reviewed Nov 17, 2022
View reviewed changes
config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml Outdated
description: "Run kueue end to end tests"
spec:
containers:
- image: golang:1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this image supports creating a kind cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. I wasn't really sure if this would work but I took an example from the descheduler e2e tests. Now that this is merged, I will see how to test this to verify everything is working.

@kannon92 kannon92 force-pushed the kueue-e2e-test branch 3 times, most recently from aa2b7f9 to 33ed8a4 Compare November 22, 2022 14:52
@kannon92 kannon92 changed the title WIP: Kueue E2E Tests Kueue E2E Tests Nov 22, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2022
@alculquicondor
Copy link
Member

/lgtm
/approve
Let's be ready to revert if this doesn't work.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
pohly
pohly reviewed Nov 22, 2022
View reviewed changes
config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml
- test-e2e-kind
# docker-in-docker needs privileged mode
securityContext:
privileged: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which E2E tests is this supposed to run?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-sigs/kueue/tree/main/test/e2e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones from https://github.com/kubernetes-sigs/kueue/tree/main/test/e2e I suppose....

I don't see anything obviously wrong, but I'm not an expert for Prow configs.

@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2022
@kannon92
Copy link
Contributor Author

I realize I should've done this in a different order.

Next time, I add tests to prow. I realize I should get the prow config merged first so then I can run the testing from the other repo.

Sorry about that.

@alculquicondor
Copy link
Member

/hold

I think this is fine. Just add the optional for now. We will see if there are errors in other PRs, we have plenty coming up :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@alculquicondor
Copy link
Member

/hold cancel
but there is a lint error :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2022
@kannon92
Copy link
Contributor Author

/hold cancel but there is a lint error :)

Thanks. Sorry about that.

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d17d0d into kubernetes:master Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-presubmits.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml

In response to this:

PR kubernetes-sigs/kueue#421 adds e2e tests to Kueue and we want to add a e2e test in the testgrid.

I think we should merge once the above PR is merged.

Partial kubernetes-sigs/kueue#61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kannon92 kannon92 mentioned this pull request Nov 29, 2022
Closed
9 tasks
@ahg-g ahg-g mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kannon92 @k8s-ci-robot @k8s-triage-robot @alculquicondor @pohly