Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding branch_protection to the kernel-module-management project. #28198

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Dec 7, 2022

Making all Github actions running on PRs mandatory for merge.

Signed-off-by: Yoni Bettan yonibettan@gmail.com

Making all Github actions running on PRs mandatory for merge.

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
@qbarrand
Copy link
Contributor

qbarrand commented Dec 7, 2022

Is it going to work without the e2e prefix?

image

@ybettan
Copy link
Contributor Author

ybettan commented Dec 7, 2022

It is supposed to.
The e2e prefix is just the workflow name, not the job name.

I have taken an example PR in the kustomize project which do the same.
image
This is how it is configured for kustomize:

kustomize:
  required_status_checks:
    contexts:
      - Lint
      - Test Linux
      - Test MacOS
      - Test Windows

So my conclusion what that tide will only look at the job's names (not the workflow).

@qbarrand
Copy link
Contributor

qbarrand commented Dec 7, 2022

Excellent, thanks @ybettan. Let us give it a try.
/lgtm
/assign @chases2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@cblecker
Copy link
Member

cblecker commented Dec 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8949d0a into kubernetes:master Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

@ybettan: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Making all Github actions running on PRs mandatory for merge.

Signed-off-by: Yoni Bettan yonibettan@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan ybettan deleted the branch-protection branch December 7, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants