Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous node e2e docker validation test. #283

Merged

Conversation

Random-Liu
Copy link
Member

This is the test infra side change of node e2e docker validation test.

/cc @pwittrock for the job config almost directly copied from node e2e test.
/cc @wonderfly for the change of continuous-docker-validation.yaml.

os-distro:
- 'gci': # continuous-docker-validation-gci
job:
- 'continuous-e2e-docker-validation-gci': # continuous-e2e-docker-validation-gci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job doesn't have a trigger-config any more. Will it stop running?

@wonderfly
Copy link
Contributor

You may also want opinions from the test-infra maintainers such as @ixdy @spxtr and @fejta, for the yaml changes

@Random-Liu Random-Liu force-pushed the continuous-docker-validation-node-e2e branch from 83a38c0 to 13f53ce Compare July 14, 2016 23:41
@Random-Liu
Copy link
Member Author

Random-Liu commented Jul 14, 2016

@wonderfly Sorry, I completely change the PR just now. Really not familiar with Jenkins, :P.
It seems that the two test are quite different, it's really hard to combine them using the same job template. So I just let them use different template in the updated commit.

And also /cc @ixdy @spxtr @fejta,

@Random-Liu Random-Liu force-pushed the continuous-docker-validation-node-e2e branch from 13f53ce to 8756427 Compare July 14, 2016 23:52
@wonderfly
Copy link
Contributor

LGTM

@Random-Liu
Copy link
Member Author

@ixdy @spxtr @fejta Could any of you take a look? Thanks! :)

@spxtr spxtr self-assigned this Jul 18, 2016
@spxtr
Copy link
Contributor

spxtr commented Jul 20, 2016

Looks fine to me.

@Random-Liu
Copy link
Member Author

@spxtr Thanks for reviewing!

@Random-Liu Random-Liu merged commit dfcd0b3 into kubernetes:master Jul 20, 2016
@Random-Liu Random-Liu deleted the continuous-docker-validation-node-e2e branch July 20, 2016 17:44
mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
ClusterLoader - Removing stop action from load config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants