stop using deprecated alias for push-build #2867
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
| @@ -34,7 +34,7 @@ if [[ "${rc}" == 0 ]]; then | |||
| echo "Kubernetes version missing; not uploading ci artifacts." | |||
| rc=1 | |||
| else | |||
| bazel run //:ci-artifacts -- "gs://kubernetes-release-dev/bazel/${version}" && rc=$? || rc=$? | |||
| bazel run //:push-build -- "gs://kubernetes-release-dev/bazel/${version}" && rc=$? || rc=$? | |||
There was a problem hiding this comment.
I don't think we cherry-picked this to 1.6 (yet). I meant to, though.
There was a problem hiding this comment.
I'll not change 1-6.sh for now. I don't think it's a big deal if we don't cherrypick.
| @@ -39,7 +39,7 @@ if [[ "${rc}" == 0 ]]; then | |||
| rc=1 | |||
| else | |||
| version="${PULL_NUMBER:-batch}/${PULL_REFS:-}" | |||
| bazel run //:ci-artifacts -- "gs://kubernetes-release-dev/bazel/${version}" && rc=$? || rc=$? | |||
There was a problem hiding this comment.
we might need to special-case for the release-1.6 branch though?
There was a problem hiding this comment.
|
it should be safe to merge this now. |
|
Also IMO it makes more sense to use |
|
@fejta that is out of scope for this PR. this PR is simply switching to the non-deprecated target (see https://github.com/kubernetes/kubernetes/blob/d3b740bf28743b3fb781e2f75ebdc5b201c60877/build/root/BUILD.root#L22-L34) and has no other functional changes. #2732 is a more reasonable place to direct this feedback. |
No description provided.