Add kubebuilder image build #28803
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| postsubmits: | ||
|
|
||
| kubernetes-sigs/kubebuilder: | ||
| - name: post-kubebuilder-push-images | ||
| cluster: k8s-infra-prow-build-trusted | ||
| annotations: | ||
| testgrid-dashboards: sig-api-machinery-kubebuilder | ||
| decorate: true | ||
| branches: | ||
| - ^master$ | ||
|
There was a problem hiding this comment. Why we need to use master? There was a problem hiding this comment. Ohh it is not required. There was a problem hiding this comment. Yes it should be just against the tag. I don't think any changes in the branch need to trigger. @camilamacedo86 could you confirm? There was a problem hiding this comment. We do not trigger change anything on the master to build the proxy image. Only its own branch. |
||
| - ^kube-rbac-proxy-releases$ | ||
| spec: | ||
| serviceAccountName: gcb-builder | ||
| containers: | ||
| - image: gcr.io/k8s-staging-test-infra/image-builder:v20230111-cd1b3caf9c | ||
| command: | ||
| - /run.sh | ||
|
There was a problem hiding this comment. It should build the proxy image right? To build today we call: https://github.com/kubernetes-sigs/kubebuilder/blob/kube-rbac-proxy-releases/build/cloudbuild_kube-rbac-proxy.yaml Which will call https://github.com/kubernetes-sigs/kubebuilder/blob/kube-rbac-proxy-releases/build/build.sh passing the tag version to do the job. So, what this run.sh does? There was a problem hiding this comment. I thought the run.sh will run initially which is present inside the image-builder. There was a problem hiding this comment.
To be non-disruptive, do we need to create another cloudbuild.yaml as here? Not entirely sure so keeping the PR as a draft (kubernetes-sigs/kubebuilder#3246). cc: @camilamacedo86 There was a problem hiding this comment. Hi @varshaprasad96,
I do not think that we need to have other cloudbuild.yaml However, the new infra should build the images to the new registry So, we need to change that to receive this info as an ARG OR just create another for the new infra. |
||
| args: | ||
| - --project=k8s-staging-kubebuilder | ||
| - --scratch-bucket=gs://k8s-staging-kubebuilder-gcb | ||
| - --env-passthrough=PULL_BASE_REF | ||
| - --with-git-dir | ||
| - . | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashsingh74 from where did you find this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this from here - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L20