Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (kubebuilder) new config image job for kube-rbac-proxy image #29351

Merged
merged 1 commit into from
May 10, 2023
Merged

✨ (kubebuilder) new config image job for kube-rbac-proxy image #29351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions config/jobs/image-pushing/k8s-staging-kubebuilder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
postsubmits:
kubernetes-sigs/kubebuilder:

- name: post-kube-rbac-proxy-push-images
cluster: k8s-infra-prow-build-trusted
annotations:
testgrid-dashboards: sig-api-machinery-kubebuilder, sig-k8s-infra-gcb
decorate: true
run_if_changed: "^kube-rbac-proxy-releases/"
branches:
- ^kube-rbac-proxy-releases$
spec:
serviceAccountName: gcb-builder
containers:
- image: gcr.io/k8s-staging-test-infra/image-builder:v20230111-cd1b3caf9c
command:
- /run.sh
args:
- --project=k8s-staging-kubebuilder
- --scratch-bucket=gs://k8s-staging-kubebuilder-gcb
- --env-passthrough=PULL_BASE_REF
- --with-git-dir
- --gcb-config=build/cloudbuild_kube-rbac-proxy.yaml
- .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: instead of using --gcb-config here, probably you want to create a new directory in https://github.com/kubernetes-sigs/kubebuilder/tree/kube-rbac-proxy-releases with a proper cloudbuild, and point to that directory

eg.:

args:
....
  - images/

And add a new cloudbuild.yaml inside this directory (see https://github.com/kubernetes/ingress-nginx/blob/main/cloudbuild.yaml). In this case if you want to test different combinations of cloudbuild.yaml later you won't need to change the one that is already working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see it here: https://github.com/kubernetes-sigs/kubebuilder/pull/3362/files

let me continue the discussion there

Copy link
Contributor Author

@camilamacedo86 camilamacedo86 May 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I understand that is right. Am I right?

See that I am doing like : https://github.com/kubernetes/test-infra/blob/3b85f96f30d6f1ce48639ccbdbde396cc3c8b183/config/jobs/image-pushing/k8s-staging-kustomize.yaml#LL28C1-L38C18

Note that for Kubebuilder, we do not use docker to build the image.

So, I understand that when we merge this one, we should see a new trigger created in the GCP, such as we have now:

Screenshot 2023-05-07 at 07 28 48

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this suggestion, but not blocking
put a hold in case