Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Optimize presubmit and periodic jobs #29621

Merged
merged 3 commits into from
May 30, 2023
Merged

CAPI: Optimize presubmit and periodic jobs #29621

merged 3 commits into from
May 30, 2023

Conversation

furkatgofurov7
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 29, 2023
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7 furkatgofurov7 changed the title WIP: Optimize presubmit periodic capi jobs WIP: CAPI: Optimize presubmit and periodic jobs May 29, 2023
@pbetkier pbetkier mentioned this pull request May 29, 2023
Closed
@furkatgofurov7 furkatgofurov7 mentioned this pull request May 29, 2023
Merged
@furkatgofurov7 furkatgofurov7 force-pushed the optimize-presubmit-periodic-capi-jobs branch from 701827b to 1b9f5db Compare May 29, 2023 10:50
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7 furkatgofurov7 changed the title WIP: CAPI: Optimize presubmit and periodic jobs CAPI: Optimize presubmit and periodic jobs May 30, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request May 30, 2023
Closed
@furkatgofurov7
Copy link
Member Author

Thanks for review @sbueringer pushed as a separate commit (a177c55) for easier re-review

@furkatgofurov7
Copy link
Member Author

/cc @killianmuldoon

@sbueringer
Copy link
Member

Thx!

/lgtm
/assign @killianmuldoon

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
killianmuldoon
killianmuldoon reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(pending the CI coming back online)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@furkatgofurov7
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 37eb5df into kubernetes:master May 30, 2023
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

Fixes: kubernetes-sigs/cluster-api#8224

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7 furkatgofurov7 deleted the optimize-presubmit-periodic-capi-jobs branch May 30, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizing presubmit and periodic jobs
4 participants
@furkatgofurov7 @sbueringer @k8s-ci-robot @killianmuldoon