-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate kwok jobs to community clusters #29731
Conversation
Signed-off-by: Anurag <contact.anurag7@gmail.com>
Welcome @kranurag7! |
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for submitting this @kranurag7! There is one modification that'll be needed for each of the jobs before we're ok to test. The Google-owned clusters did not require any resource definitions whereas the community-owned clusters do. For each of the containers in this job, can you please work with the kwok owners (@Huang-Wei and @wzshiming) to determine what good memory/cpu quotas would be? |
/ok-to-test |
@@ -55,6 +58,7 @@ presubmits: | |||
- name: pull-kwok-e2e-test-main | |||
decorate: true | |||
path_alias: sigs.k8s.io/kwok | |||
cluster: eks-prow-build-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests:
memory: "1Gi"
cpu: "1"
limits:
memory: "2Gi"
cpu: "2"
I'm not sure of the exact request but I think it should be enough, if not I'll add more 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other point of note, the pull-test-infra-unit
requires guaranteed QoS so the requests will need to match the limits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks
requests:
memory: "2Gi"
cpu: "2"
limits:
memory: "2Gi"
cpu: "2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kranurag7 are you still working on this PR? |
@rjsadow Thanks for the ping, I'll update the PR today. |
Signed-off-by: Anurag <contact.anurag7@gmail.com>
/retest pull-test-infra-unit-test-race-detector-nonblocking |
@wzshiming: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-test-infra-unit-test-race-detector-nonblocking |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kranurag7, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kranurag7: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
migrate kubernetes-sigs/kwok jobs to community clusters
Ref: #29722