-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kubernetes/{org,enhancements,community} jobs to eks-prow-build-cluster #29737
Migrate kubernetes/{org,enhancements,community} jobs to eks-prow-build-cluster #29737
Conversation
/assign @nikhita /assign @jeremyrickard |
ref #29722 |
@palnabarun requests and limits are required for /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, palnabarun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ameukam is there a guideline for how much CPU/mem usage limits/requests that should be put for a job? Ideally, the value should closely correlate to existing memory usage by the jobs. Is there a dashboard to show usage metrics? |
It's hard to say as each job is different and we don't have reliable monitoring on the google cluster jobs. I would recommend starting with 2 cpu and 4GB memory. We can monitor their resource usage through Kabana (eks cluster) (https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?from=now-24h&to=now) after they're merged and fine tune the capacity requirements later. |
@palnabarun we currently don't have a baseline all the prowjobs we have. what Ricky said is what we are recommending right now. |
e52237e
to
1ff1432
Compare
also, add cpu/mem limits and requests to the jobs Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
also, add cpu/mem limits and requests to the jobs Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
also, add cpu/mem limits and requests to the jobs Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
1ff1432
to
e0eef99
Compare
/lgtm |
@palnabarun: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-longterm