Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI Operator: Add needs-triage label #29741

Merged
merged 1 commit into from
Jun 20, 2023
Merged

CAPI Operator: Add needs-triage label #29741

merged 1 commit into from
Jun 20, 2023

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7
Add needs-triage label to Cluster API Operator repo
1484424 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 9, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 9, 2023
Closed
7 tasks
@furkatgofurov7
Copy link
Member Author

/cc @Fedosin @alexander-demicev @JoelSpeed

@Fedosin
Copy link
Contributor

Fedosin commented Jun 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@furkatgofurov7
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 13, 2023 21:03
alexander-demicev
alexander-demicev approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@furkatgofurov7
Copy link
Member Author

/cc @damdo

@k8s-ci-robot k8s-ci-robot requested a review from damdo June 16, 2023 11:06
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 16, 2023
Merged
@furkatgofurov7
Copy link
Member Author

/cc @dims can you please help merging this? Thank you!

damdo
damdo reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Fedosin
Fedosin approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented Jun 20, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev, dims, Fedosin, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0ecdb26 into kubernetes:master Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Part of: kubernetes-sigs/cluster-api-operator#153

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7 furkatgofurov7 deleted the add-needs-triage branch June 20, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@Fedosin Fedosin Fedosin approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@dims dims Awaiting requested review from dims

Assignees

@damdo damdo

@Fedosin Fedosin

@alexander-demicev alexander-demicev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@furkatgofurov7 @Fedosin @dims @k8s-ci-robot @damdo @alexander-demicev