-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cli-utils
jobs to eks-prow-build-cluster
#29742
Conversation
Signed-off-by: Ricky Sadowski <richard.j.sadowski@gmail.com>
/lgtm @rjsadow Remove the hold when ready. Please keep an eye on those jobs for a few days. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-hold |
@rjsadow: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change (probably due to added memory limit) seems to be causing the cli-utils stress tests to fail. Should I just make a PR to increase the memory limit? Where are the node sizes documented? |
@sdowell sorry, i missed that. Yes, I'll dig into it tomorrow morning. |
@sdowell can you please link some current examples? It looks like there were issues a few days ago but it looks like #30110 fixed it. I'm not seeing any current resource issues in grafana and the current job history seems ok. The couple failures that are there seem to be from tests failing. |
The common failure mode that I'm seeing is Here's an example where the tests passed but the job failed before posting a status (with the above error): https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cli-utils/622/cli-utils-presubmit-master-stress/1682149784174989312 |
This might be more related to kubernetes/k8s.io#5473. I too have seen those |
@rjsadow That would be great if that is okay with you. We're currently blocked on submitting PRs and would prefer not to disable the presubmit if possible. I appreciate it, I understand this probably makes your job harder with the migration effort. We can move back to the eks cluster once the Node health issue is better understood - does that work for you? |
This PR transitions the
cli-utils
jobs from thedefault
cluster toeks-prow-build-cluster
ref: #29722