-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate kubernetes/cluster-api-provider-azure jobs to eks cluster #29755
migrate kubernetes/cluster-api-provider-azure jobs to eks cluster #29755
Conversation
Hi @iftachk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...s-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml
Outdated
Show resolved
Hide resolved
...s/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
Outdated
Show resolved
Hide resolved
...s/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
Outdated
Show resolved
Hide resolved
@iftachk, based on #29722 (comment), we'll need to revert the changes for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can't migrate any of the jobs that depend on preset-azure-cred-only
currently as those need the GCP secrets to authenticate to create Azure resources. Only the "build" and "test" jobs can be migrated for now
Identify your CI jobs that do not depend on external cloud assets, for example unit test, linting, build. Jobs that e.g. create external GCP e2e clusters are not good candidates at this time as we're focusing on migrating
https://groups.google.com/a/kubernetes.io/g/dev/c/H5-G2bQGgds
@rjsadow @CecileRobertMichon
These are not only Please let me know if that list works for you |
@iftachk everything in that list is good except |
|
...s/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
Outdated
Show resolved
Hide resolved
5e728af
to
b6cf2bf
Compare
/ok-to-test |
- Add missing resource blocks - exclude jobs with `preset-azure-creds-only` label Signed-off-by: Iftach Konshtok <iftash@gmail.com>
b6cf2bf
to
19c1250
Compare
@CecileRobertMichon, the PR has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jackfrancis
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iftachk, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@iftachk: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jobs: migrate kubernetes/cluster-api-provider-azure jobs to eks cluster
/priority important-longterm
/area jobs
Part of #29722