Update k-csi gen-jobs to enable different clusters to be used
#29812
Conversation
k8s-ci-robot
requested review from
jsafrane,
msau42,
pohly,
saad-ali and
xing-yang
k8s-ci-robot
added
cncf-cla: yes
|
Should I commit the changes to the job files that were made with the updated |
|
It's manual, so please include the generated files in this PR. |
| # Declare an associative array | ||
| declare -A cluster_mapping | ||
|
|
||
| cluster_mapping["eks-prow-build-cluster"]="external-snapshotter external-resizer" |
There was a problem hiding this comment.
This seems complicated. Wouldn't it be simpler to do a switch?
case "$repo" in
external-snapshotter|external-resizer) echo "eks-prow-build-cluster";;
*) echo "default"
There was a problem hiding this comment.
Sure, I can update it to a case. Personally, I think the array structure will be more clean when dealing with all of the repos under csi.
There was a problem hiding this comment.
The variable may be simpler, but the shell code to work with it isn't.
There was a problem hiding this comment.
Fair enough, I'll update it and add in the generated files in the next few hours.
| # Declare an associative array | ||
| declare -A cluster_mapping | ||
|
|
||
| cluster_mapping["eks-prow-build-cluster"]="external-snapshotter external-resizer" |
There was a problem hiding this comment.
why only snapshotter and resizer repos?
There was a problem hiding this comment.
I suppose to migrate in steps?
There was a problem hiding this comment.
Exactly, I loosely plan on doing three to four follow on PRs to migrate all the repos.
| cpu: 4 | ||
| limits: | ||
| memory: "9Gi" | ||
| cpu: 4 |
There was a problem hiding this comment.
These resources seem too much. The suggestion from #29722 (comment) is to start with 2 CPUs (which mirrors the previous 2000m) and 4GB, then watch https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?from=now-24h&to=now to see the actual usage.
There was a problem hiding this comment.
The original requests made for all csi jobs were 2 CPU and 9 GB. I agree that the 4 cpu and 6 cpu for build jobs is likely a bit high. I'll probably lower it to 2 and 4 CPU respectively.
There was a problem hiding this comment.
The original requests made for all csi jobs were 2 CPU and 9 GB.
No, not quite. That was only for jobs which need to build Kubernetes from source. Everything else used "cpu: 2000m".
Let's use the original 2 cpu, 9 GiB for build jobs and 2 cpu, 4 GiB for the rest.
There was a problem hiding this comment.
Ok, thanks for clarifying! Will update.
k8s-ci-robot
added
size/XXL
Signed-off-by: Ricky Sadowski <richard.j.sadowski@gmail.com>
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@rjsadow: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There are three parts to this PR:
external-snapshotterandexternal-resizerjobs to the EKS cluster.ref: #29722
ref: #29763
/cc @msau42 @saad-ali @xing-yang @jsafrane @pohly