-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate EBS CSI driver jobs to EKS cluster #29831
migrate EBS CSI driver jobs to EKS cluster #29831
Conversation
/lgtm |
It looks like a lot of these jobs have preset-aws-credential-aws-oss-testing labels which means they likely arn't going to migrate to the EKS cluster easily. We should remove any of those tests. /remove-lgtm |
@rjsadow Is there documentation you can point me at on what that controls? I searched around but couldn't find anything. E.g. why do the unit tests need it? |
@tzneal great question, I don't have any specific information on
I do agree from looking at https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/Makefile that the unit testing and verify tests will probably be fine to move to the EKS cluster and we can likely just remove that label from those tests. Based on a comment in https://github.com/kubernetes/test-infra/pull/27108/files it looks like it's needed to get access to the aws testing account. Alternatively, it looks like that secret has been migrated to the |
13566a1
to
c187d91
Compare
/lgtm |
/cc @bertinatto @ConnorJC3 @gyuho @leakingtapan @torredil @wongma7 for approval |
@rjsadow: GitHub didn't allow me to request PR reviews from the following users: for, approval. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil, tzneal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tzneal: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of #29722
/priority important-longterm
/area jobs