Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate EBS CSI driver jobs to EKS cluster #29831

Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jun 16, 2023

Part of #29722

/priority important-longterm
/area jobs

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 16, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Jun 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Jul 17, 2023

It looks like a lot of these jobs have preset-aws-credential-aws-oss-testing labels which means they likely arn't going to migrate to the EKS cluster easily. We should remove any of those tests.

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@tzneal
Copy link
Contributor Author

tzneal commented Jul 17, 2023

@rjsadow Is there documentation you can point me at on what that controls? I searched around but couldn't find anything. E.g. why do the unit tests need it?

@rjsadow
Copy link
Contributor

rjsadow commented Jul 17, 2023

@tzneal great question, I don't have any specific information on preset-aws-credential-aws-oss-testing but generally speaking we've been trying to avoid migrating jobs that have specific credential requirements. We do have some documentation that talks about that here.

IMPORTANT: if you see any entries under label or volumeMounts that might indicate that a job is using some external non-GCP resource (e.g. credentials for some cloud platform), you need to check if the Community Ownership criteria is satisfied for that resource (see the Community Ownership section for more details)

I do agree from looking at https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/Makefile that the unit testing and verify tests will probably be fine to move to the EKS cluster and we can likely just remove that label from those tests. Based on a comment in https://github.com/kubernetes/test-infra/pull/27108/files it looks like it's needed to get access to the aws testing account.

Alternatively, it looks like that secret has been migrated to the k8s-infra-prow-build cluster per #27861. So for now we should be able to move the e2e/external tests there so they're at least running on a community owned cluster.

@tzneal tzneal force-pushed the migrate-ebs-jobs-to-eks-cluster branch from 13566a1 to c187d91 Compare August 24, 2023 01:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Aug 24, 2023

/lgtm
/cc @ameukam

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Aug 29, 2023

/cc @bertinatto @ConnorJC3 @gyuho @leakingtapan @torredil @wongma7 for approval

@k8s-ci-robot
Copy link
Contributor

@rjsadow: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bertinatto @ConnorJC3 @gyuho @leakingtapan @torredil @wongma7 for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit e8a992f into kubernetes:master Aug 29, 2023
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@tzneal: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml

In response to this:

Part of #29722

/priority important-longterm
/area jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants