Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API: Add area/provider-in-memory label #29872

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Cluster API: Add area/provider-in-memory label #29872

merged 1 commit into from
Aug 10, 2023

Conversation

killianmuldoon
Copy link
Contributor

Add an area/provider-in-memory to the Cluster API areas label list.

@killianmuldoon
Cluster API: Add area/provider-in-memory label
7cf7aac 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jun 20, 2023
Merged
@sbueringer
Copy link
Member

Thank you!

/lgtm

/assign @cblecker

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@sbueringer
Copy link
Member

/assign @MadhavJivrajani

MadhavJivrajani
MadhavJivrajani approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@MadhavJivrajani
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@MadhavJivrajani
Copy link
Contributor

/hold cancel
Sorry wanted to check one more thing, all good.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff83158 into kubernetes:master Aug 10, 2023
4 checks passed
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Updated the label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Add an area/provider-in-memory to the Cluster API areas label list.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@aojea aojea Awaiting requested review from aojea

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@cblecker cblecker

@sbueringer sbueringer

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @MadhavJivrajani @cblecker