Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kubernetes/aws-load-balancer-controller jobs to eks cluster #29879

Merged
merged 1 commit into from
Jul 1, 2023
Merged

migrate kubernetes/aws-load-balancer-controller jobs to eks cluster #29879

merged 1 commit into from
Jul 1, 2023

Conversation

iftachk
Copy link
Contributor

@iftachk iftachk commented Jun 20, 2023 •
edited
Loading

jobs: migrate kubernetes/aws-load-balancer-controller jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @iftachk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2023
rjsadow
rjsadow suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@rjsadow rjsadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wont be able to migrate the pull-aws-load-balancer-controller-e2e-test job as it relies on secrets only avail in the GCP cluster at this time.

@iftachk
jobs: migrate kubernetes/aws-load-balancer-controller jobs to eks clu…
e14c887 
…ster

- Add missing resource blocks

Signed-off-by: Iftach Konshtok <iftash@gmail.com>
@iftachk iftachk force-pushed the migrate-aws-load-balancer-controller-jobs branch from a6a19ee to e14c887 Compare June 20, 2023 16:13
@rjsadow rjsadow mentioned this pull request Jun 20, 2023
Closed
54 tasks
@rjsadow
Copy link
Contributor

rjsadow commented Jun 20, 2023

/ok-to-test
/lgtm
Thanks @iftachk!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2023
@ameukam
Copy link
Member

ameukam commented Jul 1, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, iftachk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit b92d415 into kubernetes:master Jul 1, 2023
@k8s-ci-robot
Copy link
Contributor

@iftachk: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key aws-alb-ingress-controller-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-load-balancer-controller/aws-alb-ingress-controller-presubmits.yaml

In response to this:

jobs: migrate kubernetes/aws-load-balancer-controller jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid upodroid mentioned this pull request Jul 13, 2023
Closed
@rjsadow rjsadow mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsadow rjsadow rjsadow requested changes

@bigkraig bigkraig Awaiting requested review from bigkraig

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iftachk @k8s-ci-robot @rjsadow @ameukam