Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining containerd-build-* jobs to the community bucket and introduce postsubmit jobs #30025

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jul 7, 2023

Follow up to #29986
Part of kubernetes/k8s.io#1469
Part of #29722
Fixes #29995

I did a few changes:

  • The build jobs now run as postsubmits. A build is triggered when a commit is merged on the relevant branches instead of building containerd every 30 minutes. (We can use that compute to test something more useful)
  • The CI job runs once a day.
  • I updated the OWNERS file in containerd folder to match the sig-node folder
  • containerd jobs will be running on community infrastructure

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2023
@upodroid
Copy link
Member Author

upodroid commented Jul 7, 2023

/cc @dims @tzneal

@k8s-ci-robot k8s-ci-robot requested review from dims and tzneal July 7, 2023 16:43
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 7, 2023
@upodroid upodroid force-pushed the optimise-containerd-jobs branch 3 times, most recently from 125dae0 to a5d2494 Compare July 7, 2023 23:01
@dims
Copy link
Member

dims commented Jul 8, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member Author

upodroid commented Jul 8, 2023

/retest

@upodroid
Copy link
Member Author

/cc @SergeyKanzhelev

This is ready to be merged.

@bart0sh
Copy link
Contributor

bart0sh commented Jul 19, 2023

/assign @SergeyKanzhelev

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 19, 2023
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few comments on the changes:

Also 2 follow up changes need to be done:

  1. The default bucket referred in containerd/containerd should also be changed.
  2. References to cri-containerd-staging in the env files used for deploying VMs with containerd should be changed, else those node-e2e jobs will start failing.

@upodroid
Copy link
Member Author

  • The default bucket referred in containerd/containerd should also be changed.
  • References to cri-containerd-staging in the env files used for deploying VMs with containerd should be changed, else those node-e2e jobs will start failing.
  1. Not really required and might break other users
  2. I will do this in a separate PR once this is merged. The old bucket will still be available but it will have stale containerd builds(by a few days which isn't critical).

Can I get a LGTM?

@akhilerm
Copy link
Member

@upodroid I had one more question here #30025 (comment)

@upodroid
Copy link
Member Author

As I said earlier, we can merge this PR now and I can open a separate one to adjust the containerd env files. I'll open it today for review. We'll have stale builds for containerd for a few hours/days after this is merged depending on how fast PRs are being merged in containerd.

@akhilerm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8b3838c into kubernetes:master Jul 21, 2023
8 checks passed
SIG Node CI/Test Board automation moved this from Triage to Done Jul 21, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd-periodic-jobs.yaml using file config/jobs/containerd/containerd/containerd-periodic-jobs.yaml
  • key containerd-postsubmit-jobs.yaml using file config/jobs/containerd/containerd/containerd-postsubmit-jobs.yaml
  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Follow up to #29986
Part of kubernetes/k8s.io#1469
Part of #29722
Fixes #29995

I did a few changes:

  • The build jobs now run as postsubmits. A build is triggered when a commit is merged on the relevant branches instead of building containerd every 30 minutes. (We can use that compute to test something more useful)
  • The CI job runs once a day.
  • I updated the OWNERS file in containerd folder to match the sig-node folder
  • containerd jobs will be running on community infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use a community-owned bucket k8s-staging-cri-tools instead of cri-containerd-staging
7 participants