-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull containerd binaries from gs://k8s-staging-cri-tools
bucket
#30153
Pull containerd binaries from gs://k8s-staging-cri-tools
bucket
#30153
Conversation
/hold I'll cancel it once the bucket is populated |
/approve |
There is a snag. Some of the env files are used by containerd/containerd node-e2e presubmits and fixing those jobs to use kubetest2 + migrate to community cluster is hard. Details are at #30159 I can allow the pr-kubekins@kubernetes-jenkins-pull.iam.gserviceaccount.com service account to write to the community bucket and merge it on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhilerm, dims, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While doing
|
Those are PRs that were built and used in a containerd/containerd e2e test. |
As soon as containerd/containerd#8862 is merged, I'll cancel the hold from this build. We are currently testing 5 commits behind for jobs that test against containerd's HEAD. https://github.com/containerd/containerd/compare/6eb90a6..59959b3 |
/hold cancel |
There is a circular dependancy. The change in containerd doesn't work because the env file still has the old bucket. I'll merge this PR which should allow the e2e tests in |
/cc @akhilerm @dims @SergeyKanzhelev
Part of #29995
The bucket is still missing release binaries jobs, it will be populated in 24 hours.