-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a janitor periodic job to cleanup stale ec2 instances from the node-e2e-tests service account #30395
Conversation
Do the actual cluster nodes run in this account, or just the test launched nodes? |
@tzneal |
/hold cross checking my query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I recommend you use the boskos janitor, have a look at maintenance-ci-aws-janitor job - interval: 1h
name: maintenance-ci-aws-janitor
labels:
preset-service-account: "true"
preset-aws-ssh: "true"
preset-aws-credential: "true"
decorate: true
spec:
containers:
- command:
- /app
args:
- --ttl=2h30m
- --path=s3://k8s-kops-prow/objs.json
image: gcr.io/k8s-staging-boskos/aws-janitor:v20230524-a7ef97e
annotations:
testgrid-dashboards: sig-testing-maintenance
testgrid-tab-name: ci-aws-janitor
description: Deletes old AWS resources That janitor can target resources by tags after the defined ttl. https://github.com/kubernetes-sigs/boskos/blob/master/cmd/aws-janitor/main.go |
…de-e2e-tests service account Signed-off-by: Davanum Srinivas <davanum@gmail.com>
1b3287a
to
67d6374
Compare
@upodroid happy to iterate, i want to start with something simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it to the todo list
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, tzneal, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@dims: Updated the
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.