Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API: bump periodics to kubekins 1.28 #30462

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Cluster API: bump periodics to kubekins 1.28 #30462

merged 1 commit into from
Aug 23, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 22, 2023 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

Part of #8708

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2023
@sbueringer
Copy link
Member Author

/assign @killianmuldoon @chrischdi @fabriziopandini @furkatgofurov7

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/hold
want to merge and verify presubmits first

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 22, 2023
@sbueringer sbueringer changed the title Cluster API: bump periodics to kubekins 1.28i Cluster API: bump periodics to kubekins 1.28 Aug 22, 2023
@sbueringer
Cluster API: bump periodics to kubekins 1.28
56bfb1a 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer mentioned this pull request Aug 22, 2023
Closed
13 tasks
@killianmuldoon
Copy link
Contributor

I think this should be marked as part of kubernetes-sigs/cluster-api#8708 - wrong repo in the description.

@sbueringer
Copy link
Member Author

Thx, fixed in both!

killianmuldoon
killianmuldoon reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@chrischdi
Copy link
Member

/lgtm

1 similar comment
@fabriziopandini
Copy link
Member

/lgtm

@sbueringer
Copy link
Member Author

/hold cancel

Confirmed that presubmits work with this PR (kubernetes-sigs/cluster-api#9275). Which is currently getting merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 31fedad into kubernetes:master Aug 23, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml

In response to this:

Signed-off-by: Stefan Büringer buringerst@vmware.com

Part of #8708

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-capi-1.28-periodics branch August 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sbueringer @k8s-ci-robot @killianmuldoon @chrischdi @fabriziopandini @furkatgofurov7