-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPI: Make most presubmits blocking #30709
CAPI: Make most presubmits blocking #30709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nits
please also update jobs.md in core CAPI accordingly
Thx for taking care of this!
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-4.yaml
Outdated
Show resolved
Hide resolved
be64180
to
b2cbb67
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
b2cbb67
to
a13902f
Compare
Thank youuuu!! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make most of the presubmit jobs for Cluster API blocking on PRs by making them non-optional. The jobs which are still optional are:
pull-cluster-api-e2e-scale-main-experimental
which is experimental and should not block.pull-cluster-api-apidiff-main
which needs to be optional to allow api changes in PRs.pull-cluster-api-e2e-informing-release-1-5
which is explicitly optional - i.e. pr informing rather than blocking.pull-cluster-api-e2e-informing-ipv6-release-1-4
which is explicitly optional - i.e. pr informing rather than blockingpull-cluster-api-e2e-informing-ipv6-release-1-3
which is explicitly optional - i.e. pr informing rather than blocking