CAPI: Make most presubmits blocking #30709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
sbueringer
reviewed
Sep 14, 2023
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-4.yaml
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-capi-presubmit-blocking
branch
from
be64180
to
b2cbb67
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-capi-presubmit-blocking
branch
from
b2cbb67
to
a13902f
Compare
This was referenced Sep 14, 2023
|
Thank youuuu!! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@killianmuldoon: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make most of the presubmit jobs for Cluster API blocking on PRs by making them non-optional. The jobs which are still optional are:
pull-cluster-api-e2e-scale-main-experimentalwhich is experimental and should not block.pull-cluster-api-apidiff-mainwhich needs to be optional to allow api changes in PRs.pull-cluster-api-e2e-informing-release-1-5which is explicitly optional - i.e. pr informing rather than blocking.pull-cluster-api-e2e-informing-ipv6-release-1-4which is explicitly optional - i.e. pr informing rather than blockingpull-cluster-api-e2e-informing-ipv6-release-1-3which is explicitly optional - i.e. pr informing rather than blocking