Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate gcp pd driver to k8s-infra-prow-build #30757

Merged
merged 1 commit into from
Sep 19, 2023
Merged

migrate gcp pd driver to k8s-infra-prow-build #30757

merged 1 commit into from
Sep 19, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 19, 2023

@ameukam
migrate gcp pd driver to k8s-infra-prow-build
6833db6 
Related to:
  - kubernetes#30277

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@ameukam
Copy link
Member Author

ameukam commented Sep 19, 2023

cc @dims @rjsadow

@rjsadow
Copy link
Contributor

rjsadow commented Sep 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 146fa2d into kubernetes:master Sep 19, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/config.yaml
  • key gcp-compute-persistent-disk-csi-driver-postsubmits.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/gcp-compute-persistent-disk-csi-driver-postsubmits.yaml
  • key gcp-compute-persistent-disk-csi-driver-windows.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/gcp-compute-persistent-disk-csi-driver-windows.yaml

In response to this:

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pwschuurman
Copy link
Contributor

GCP PD Driver e2e tests started failing: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1374/pull-gcp-compute-persistent-disk-csi-driver-e2e/1704550819682062336

This is because the tests call cloudresourcemanager.googleapis.com: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/e2e/utils/utils.go#L139

@ameukam Do you have any visibility into how the Service Account credentials change in k8s-infra-prow-build?

@ameukam
Copy link
Member Author

ameukam commented Sep 20, 2023

GCP PD Driver e2e tests started failing: prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1374/pull-gcp-compute-persistent-disk-csi-driver-e2e/1704550819682062336

This is because the tests call cloudresourcemanager.googleapis.com: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver@master/test/e2e/utils/utils.go#L139

@ameukam Do you have any visibility into how the Service Account credentials change in k8s-infra-prow-build?

@pwschuurman I think the service account in the k8s-infra-prow-build need access to gcp resources through Cloud resource manager. I'll enable the service.

ameukam added a commit to ameukam/k8s.io that referenced this pull request Sep 20, 2023
@ameukam
GCP/prow-build: Enabled Cloud Resource Manager service
5d978b0 
Follow of:
 - kubernetes/test-infra#30757

Some E2E tests requires the service to be enabled. Failure on https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1375/pull-gcp-compute-persistent-disk-csi-driver-e2e/1704443546796298240/

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
This was referenced Sep 20, 2023
Merged
Merged
ameukam added a commit to ameukam/test-infra that referenced this pull request Sep 22, 2023
@ameukam
move back pull-gcp-compute-persistent-disk-csi-driver-e2e
8882972 
Follow-up of:
  - kubernetes#30757

Some E2E tests related to disk encryption with a custom CMEK key fails
to run successfully on k8s-infra. moving back the job until we identify
the root cause.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@msau42 msau42 Awaiting requested review from msau42

Assignees

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @k8s-ci-robot @rjsadow @pwschuurman