-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kubekins v2 image #31421
Create kubekins v2 image #31421
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kubernetes/release-engineering |
@upodroid: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-engineering. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold I need to create the prowjobs and the bumper for the new image. I'll cancel this hold once that PR is merged |
/retest |
Hello, can I get lgtm on this PR please? |
/cc @dims |
images/kubekins-e2e-v2/variants.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this for the latest Go releases before merging (xref #31602)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits
The infra is ready, need a LGTM /hold cancel |
/lgtm |
I'm creating a new version of the kubekins-e2e image that can immediately replace the kubekins image usage everywhere except k/k e2e jobs and few jobs that rely on legacy tooling.
New features:
Fixes: #31273