Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external-dns: Drop linting job for PR #31422

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Dec 11, 2023

Github actions already lints so we can skip this here and safe some compute on prow.
If the licensecheck is something you'd want to preserve, we should add this to github actions as well.

Context: kubernetes-sigs/external-dns#4078 (comment)

@johngmyers @Raffo @njuettner @szuecs @mloiseleur

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 11, 2023
@Raffo
Copy link

Raffo commented Dec 28, 2023

@mrueg I am not sure if it makes more sense to save prow compute or actions compute given that actions has minutes that aren't unlimited and we don't have a specisl agreement with them like we do for prow (given that we are an official project). And yes the license check is something we absolutely need.

@Raffo
Copy link

Raffo commented Jan 2, 2024

Ok, after thinking more about this, I've seen this job blocking PRs from being merged many times and that is simply damaging the project. I would say that we can disable this and have the license check done in another place. @mrueg if you are willing to add a PR to external DNS for the license check, then I'm happy to approve this one.

@mloiseleur
Copy link
Contributor

It works for me too

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@Raffo
Copy link

Raffo commented Jan 2, 2024

@mrueg can you rebase this one?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2024
Github actions already lints so we can skip this here and safe some
compute on prow.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg
Copy link
Member Author

mrueg commented Jan 3, 2024

I've rebased and reduced it to the licensecheck target.

@Raffo
Copy link

Raffo commented Jan 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@mloiseleur
Copy link
Contributor

I'm not sure if I can, but I'll try:
/approve

@Raffo
Copy link

Raffo commented Jan 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, mrueg, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit fd53f8f into kubernetes:master Jan 3, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@mrueg: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key external-dns-presubmits.yaml using file config/jobs/kubernetes-sigs/external-dns/external-dns-presubmits.yaml

In response to this:

Github actions already lints so we can skip this here and safe some compute on prow.
If the licensecheck is something you'd want to preserve, we should add this to github actions as well.

Context: kubernetes-sigs/external-dns#4078 (comment)

@johngmyers @Raffo @njuettner @szuecs @mloiseleur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants