Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate pull-ingress-gce-e2e to use community clusters #31846

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Feb 6, 2024

This PR moves pull-ingress-gce-e2e jobs to the community owned cluster gke cluster.

ref: #30277
parent: #31681 and #31736

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 6, 2024
@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

/assign @aojea
/cc @rjsadow @ameukam

@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

/hold Wait until kubernetes/ingress-gce#2458 gets merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@ameukam
Copy link
Member

ameukam commented Feb 6, 2024

/ok-to-test
@sawsa307 do we want to change the project-type before we do this ?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2024
@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

/ok-to-test @sawsa307 do we want to change the project-type before we do this ?

Yes I added a hold on this PR, with the reference to the PR needed in the ingress-gce repo kubernetes/ingress-gce#2458.

@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

/retest

@swetharepakula
Copy link
Member

Just approved kubernetes/ingress-gce#2458, we should be able to merge this as soon as the PR in ingress-gce merges.

@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

Hi @ameukam @rjsadow we should be ready to proceed. Could you take a look at this PR and approve? Thank you!

@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@ameukam
Copy link
Member

ameukam commented Feb 6, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 6, 2024

Thanks @ameukam! After this gets merged I'll re-trigger our job and see it there is any issue.

@k8s-ci-robot k8s-ci-robot merged commit 08e434f into kubernetes:master Feb 6, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@sawsa307: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml

In response to this:

This PR moves pull-ingress-gce-e2e jobs to the community owned cluster gke cluster.

ref: #30277
parent: #31681 and #31736

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants