Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops - Migrate kops DO jobs to community-owned prow clusters #32189

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Mar 7, 2024

The issue says DigitalOcean jobs should be migrated to the trusted cluster. This migrates one of kops' 6 DigitalOcean jobs to the new cluster.

/cc @ameukam
Can you confirm these secrets are present in the new cluster?

secretKeyRef:
name: cluster-api-provider-digitalocean-token
key: DIGITALOCEAN_ACCESS_TOKEN

secretKeyRef:
name: spaces-digitalocean-s3
key: access-key

secret:
defaultMode: 0400
secretName: kops-e2e-do-ssh-key

@rifelpet rifelpet changed the title Kops - Migrate one kops DO job to community-owned prow Kops - Migrate one kops DO job to community-owned prow clusters Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 7, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Mar 7, 2024

If the secrets do exist then I'll move the job to this repo path:

func TestK8sInfraTrusted(t *testing.T) {
jobsToFix := 0
const trusted = "k8s-infra-prow-build-trusted"
trustedPath := path.Join(*jobConfigPath, "kubernetes", "sig-k8s-infra", "trusted") + "/"

@ameukam
Copy link
Member

ameukam commented Mar 7, 2024

Secrets are currently not present. Still working with CNCF to get them migrated.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Jul 8, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2024
@ameukam
Copy link
Member

ameukam commented Jul 15, 2024

@rifelpet Now kubernetes/k8s.io#6967 is merged, we can proceed with this.

@rifelpet rifelpet changed the title Kops - Migrate one kops DO job to community-owned prow clusters Kops - Migrate kops DO jobs to community-owned prow clusters Jul 15, 2024
@ameukam
Copy link
Member

ameukam commented Jul 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit e9de0f3 into kubernetes:master Jul 16, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rifelpet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-periodics-misc.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc.yaml
  • key kops-presubmits.yaml using file config/jobs/kubernetes/kops/kops-presubmits.yaml

In response to this:

The issue says DigitalOcean jobs should be migrated to the trusted cluster. This migrates one of kops' 6 DigitalOcean jobs to the new cluster.

/cc @ameukam
Can you confirm these secrets are present in the new cluster?

secretKeyRef:
name: cluster-api-provider-digitalocean-token
key: DIGITALOCEAN_ACCESS_TOKEN

secretKeyRef:
name: spaces-digitalocean-s3
key: access-key

secret:
defaultMode: 0400
secretName: kops-e2e-do-ssh-key

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rifelpet
Copy link
Member Author

rifelpet commented Jul 16, 2024

@upodroid @ameukam I confirmed these jobs are working in the new cluster: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-do-calico-gossip/1813195507388911616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants