Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kettle from k8s-gubernator to kubernetes-public #32369

Conversation

dims
Copy link
Member

@dims dims commented Apr 3, 2024

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs area/kettle area/metrics area/triage sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch 3 times, most recently from 2db1cbe to 0241e85 Compare April 3, 2024 14:51
@ameukam
Copy link
Member

ameukam commented Apr 4, 2024

we should probably drop the istio flakes: metrics/configs/istio-flakes.yaml ?

@dims
Copy link
Member Author

dims commented Apr 4, 2024

we should probably drop the istio flakes: metrics/configs/istio-flakes.yaml ?

ack, will do when i touch this PR again

@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch 2 times, most recently from 8d2c740 to 617f1f8 Compare April 15, 2024 14:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2024
@dims
Copy link
Member Author

dims commented Apr 15, 2024

everything seems to be running fine in the kettle namespace:

Every 1.0s: kubectl get pv,pvc,pod,rs,deployments -n kettle                                                                                                                                             cs-447156173551-default: Mon Apr 15 14:06:29 2024

NAME                                                        CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                      STORAGECLASS   REASON   AGE
persistentvolume/pvc-17748d8f-529f-46a9-829d-273c3831560b   10Gi       RWO            Delete           Bound    triageparty-cli/triage-party-persistence   ssd                     2y205d
persistentvolume/pvc-4941274b-9d28-4a0d-8163-190da1742e5a   100Gi      RWO            Delete           Bound    publishing-bot/publisher-gopath            ssd                     19d
persistentvolume/pvc-a021482a-480f-4840-8a3a-326eac89c278   100Gi      RWO            Delete           Bound    prow/ghproxy                               ssd                     2y246d
persistentvolume/pvc-b938b3d5-db10-4847-8f04-fd4f0253abca   3001Gi     RWO            Delete           Bound    kettle/kettle-data                         ssd                     2m35s

NAME                                STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/kettle-data   Bound    pvc-b938b3d5-db10-4847-8f04-fd4f0253abca   3001Gi     RWO            ssd            2m40s

NAME                          READY   STATUS    RESTARTS   AGE
pod/kettle-5b78cfd9cc-slgp8   1/1     Running   0          2m1s

NAME                                DESIRED   CURRENT   READY   AGE
replicaset.apps/kettle-5b78cfd9cc   1         1         1       2m1s

NAME                     READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/kettle   1/1     1            1           2m1s

deployed using the following:

kubectl apply -n kettle -f pv.yaml
kubectl apply -n kettle -f deployment.yaml

@dims dims changed the title [WIP] Move kettle from k8s-gubernator to kubernetes-public Move kettle from k8s-gubernator to kubernetes-public Apr 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@ameukam
Copy link
Member

ameukam commented Apr 15, 2024

we probably want to move metrics-kettle job at the same time ?

cc @BenTheElder

@dims
Copy link
Member Author

dims commented Apr 16, 2024

@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch from 617f1f8 to fb731e8 Compare April 16, 2024 13:40
@ameukam
Copy link
Member

ameukam commented Apr 16, 2024

we should probably drop the istio flakes: metrics/configs/istio-flakes.yaml ?

ack, will do when i touch this PR again

Still not removed?

@ameukam
Copy link
Member

ameukam commented Apr 16, 2024

@ameukam i do have the update for the metrics-kettle job in this PR itself already ( https://github.com/kubernetes/test-infra/pull/32369/files#diff-ad53ce0bff92a9240f627b89887038d06d001b6a0e7f836476ac8702ed78e707R53-R55 )

Which change the dataset but not change where the prowjob is supposed aka the cluster field is missing. If this PR is merged, metrics-kettle will fail to execute any BQ request because the default don't have the necessary IAM bindings.
(I could be wrong that's why I pinged Ben).

@dims
Copy link
Member Author

dims commented Apr 16, 2024

Which change the dataset but not change where the prowjob is supposed aka the cluster field is missing. If this PR is merged, metrics-kettle will fail to execute any BQ request because the default don't have the necessary IAM bindings.
(I could be wrong that's why I pinged Ben).

Ah gotcha!

@dims
Copy link
Member Author

dims commented Apr 16, 2024

Still not removed?

sorry! doing that now

@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch from fb731e8 to eeb743d Compare April 16, 2024 13:46
@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch from eeb743d to 0b609e1 Compare April 16, 2024 18:29
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the move-kettle-from-k8s-gubernator-to-kubernetes-public branch from 0b609e1 to 2fcc9ce Compare April 16, 2024 18:59
@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Apr 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 41c1293 into kubernetes:master Apr 17, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-test-infra.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-test-infra.yaml
  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml

In response to this:

xref: kubernetes/k8s.io#787

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kettle area/metrics area/triage cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants