Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always run pull-cluster-api-provider-vsphere-e2e-supervisor #32378

Closed
wants to merge 1 commit into from
Closed

Always run pull-cluster-api-provider-vsphere-e2e-supervisor #32378

wants to merge 1 commit into from

Conversation

fabriziopandini
Copy link
Member

We are running this job as periodic since some time now and it is stable.
Let's start running this on each PR, not blocking (but with the idea to make it blocking soon)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@fabriziopandini
Copy link
Member Author

/hold for kubernetes-sigs/cluster-api-provider-vsphere#2879 to merge first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@fabriziopandini fabriziopandini force-pushed the always-run-pull-cluster-api-provider-vsphere-e2e-supervisor branch from 81ef303 to 408247d Compare April 4, 2024 14:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@fabriziopandini
Copy link
Member Author

/hold reviewing this after discussing with other contributors

@fabriziopandini
Copy link
Member Author

/close
sending a new PR ASAP that improves maintainability

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close
sending a new PR ASAP that improves maintainability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the always-run-pull-cluster-api-provider-vsphere-e2e-supervisor branch April 18, 2024 10:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@srm09 srm09 Awaiting requested review from srm09

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziopandini @k8s-ci-robot