Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove unused secrets for capv and add janitor user #32688

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented May 31, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 31, 2024
@chrischdi
Copy link
Member Author

/assign @fabriziopandini @sbueringer

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@sbueringer
Copy link
Member

/lgtm

@chrischdi please update the PR title

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@chrischdi chrischdi changed the title config: remove now unused secret for capv config: remove unused secret for capv and add janitor user Jun 11, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

@chrischdi chrischdi force-pushed the pr-prow-cleanup-capv-gcs-secret branch from 2ff8a74 to 1575eba Compare June 17, 2024 12:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@sbueringer
Copy link
Member

/assign @ameukam

Context: we are cleaning up our VMC environment so it already works the same way as the new env. This should speed up the migration, more context:

@chrischdi chrischdi changed the title config: remove unused secret for capv and add janitor user config: remove unused secrets for capv and add janitor user Jun 17, 2024
@ameukam
Copy link
Member

ameukam commented Jun 24, 2024

/approve
/hold

Remove the hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, chrischdi, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@sbueringer
Copy link
Member

Thx!

/hold cancel

@ameukam I don't remember. Is this getting deployed automatically, or do we have to ping someone?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@chrischdi
Copy link
Member Author

Thx!

/hold cancel

@ameukam I don't remember. Is this getting deployed automatically, or do we have to ping someone?

We will see this in the audit logs of the secrets :-)

@sbueringer
Copy link
Member

Would be still interesting to know, as it also might tell us who to ping :)

@k8s-ci-robot k8s-ci-robot merged commit 52ce8aa into kubernetes:master Jun 24, 2024
5 checks passed
@chrischdi chrischdi deleted the pr-prow-cleanup-capv-gcs-secret branch June 24, 2024 08:51
@chrischdi
Copy link
Member Author

According the secret logs: the new ones get requested, the old ones stopped getting requested since 10:51 CEST, which matches ~ when this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants