Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate presubmit e2e test to use WI #32942

Merged
merged 1 commit into from
Jul 10, 2024
Merged

migrate presubmit e2e test to use WI #32942

merged 1 commit into from
Jul 10, 2024

Conversation

nawazkh
Copy link
Contributor

@nawazkh nawazkh commented Jul 10, 2024

As part of kubernetes-sigs/cluster-api-provider-azure#4976, This PR migrates pull-cluster-api-provider-azure-e2e to WI test path.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 10, 2024
@nawazkh nawazkh mentioned this pull request Jul 10, 2024
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2024
@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

/cc @jackfrancis @jsturtevant @mboersma

@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

hold for kubernetes-sigs/cluster-api-provider-azure#4939 to merge
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@jackfrancis
Copy link
Contributor

I vote that we include all tests that use ci-e2e.sh, I think we've ~proved that those tests should work. That would be:

  • pull-cluster-api-provider-azure-e2e-optional
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-capi-e2e
  • pull-cluster-api-provider-azure-e2e-workload-upgrade
  • pull-cluster-api-provider-azure-apiversion-upgrade

@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

I vote that we include all tests that use ci-e2e.sh, I think we've ~proved that those tests should work. That would be:

  • pull-cluster-api-provider-azure-e2e-optional
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-capi-e2e
  • pull-cluster-api-provider-azure-e2e-workload-upgrade
  • pull-cluster-api-provider-azure-apiversion-upgrade

Thinking of tackling it a new PR to avoid any surprises. What do you say?
A new PR with all the presubmit tests copied over to use WI. Aiming to get one green run of each of the tests to confidently migrate to WI.

@nawazkh nawazkh mentioned this pull request Jul 10, 2024
Merged
@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

New PR migrating other tests to WI for sanity check: #32944

@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

pull-test-infra-verify-lint failed with below error.
Can it be restarted on another cluster ? Looks to me like an infra throttling issue.

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/31 nodes are available: 28 Insufficient cpu, 3 node(s) had untolerated taint {node-group: stable}. preemption: 0/31 nodes are available: 28 No preemption victims found for incoming pod, 3 Preemption is not helpful for scheduling..)

@jsturtevant
Copy link
Contributor

pull-test-infra-verify-lint failed with below error. Can it be restarted on another cluster ? Looks to me like an infra throttling issue.

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/31 nodes are available: 28 Insufficient cpu, 3 node(s) had untolerated taint {node-group: stable}. preemption: 0/31 nodes are available: 28 No preemption victims found for incoming pod, 3 Preemption is not helpful for scheduling..)

yes not related to this PR

/retest

@nawazkh nawazkh changed the title migrate presubmit e2e tests to wi migrate presubmit e2e test to use WI Jul 10, 2024
@jackfrancis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 10, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 236f005 into kubernetes:master Jul 10, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nawazkh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml

In response to this:

As part of kubernetes-sigs/cluster-api-provider-azure#4976, This PR migrates pull-cluster-api-provider-azure-e2e to WI test path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nawazkh nawazkh deleted the capz_tests_with_wi branch July 10, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@jackfrancis jackfrancis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nawazkh @jackfrancis @jsturtevant @k8s-ci-robot