Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update periodic main upgrades test jobs to use WI credentials #32963

Merged

Conversation

nawazkh
Copy link
Contributor

@nawazkh nawazkh commented Jul 12, 2024

With the success of presubmit main e2e tests, this PR migrates the periodic main upgrade jobs to use WI credentials.
Since these are periodic upgrade jobs and do not immediately hinder dev flow, we can tolerate breakage of these tests(if any).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 12, 2024
@nawazkh nawazkh force-pushed the migrate_periodics_main_upgrades_2_wi branch from b257c41 to 729ae3b Compare July 12, 2024 02:09
@nawazkh nawazkh force-pushed the migrate_periodics_main_upgrades_2_wi branch from 729ae3b to 16dd1b5 Compare July 12, 2024 17:20
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2024
@nawazkh nawazkh changed the title Migrate periodics main upgrades to WI Update periodic main upgrades test jobs to use WI credentials Jul 12, 2024
@nawazkh
Copy link
Contributor Author

nawazkh commented Jul 12, 2024

/cc @jackfrancis @jsturtevant

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

let's remember to watch outcomes next week as we haven't tested the \\[K8s-Upgrade\\] ginkgo focus string yet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7fb7dba into kubernetes:master Jul 12, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nawazkh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics-main-upgrades.yaml

In response to this:

With the success of presubmit main e2e tests, this PR migrates the periodic main upgrade jobs to use WI credentials.
Since these are periodic upgrade jobs and do not immediately hinder dev flow, we can tolerate breakage of these tests(if any).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nawazkh nawazkh deleted the migrate_periodics_main_upgrades_2_wi branch July 12, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants