Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kubetest2-kops k/k conformance tests to kops prow #33820

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

rifelpet
Copy link
Member

Fixes kubernetes/kops#16938
(hopefully)

Those jobs are failing with this error:

Error: error building complete spec: failed to get bucket details for "s3://k8s-kops-ci-prow/discovery/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-canary.test-cncf-aws.k8s.io": Could not retrieve location for AWS bucket k8s-kops-ci-prow

We've seen this happen when the job is running with a different AWS account than the bucket's account.


According to #29722 (comment) the eks-prow-build-cluster is for jobs "that do not depend on external cloud assets"

These kubtest2-kops jobs depend on an existing S3 bucket for kops to function properly, so we'll move these jobs to the same prow cluster that other kops jobs use so that they share the same AWS account.

Eventually when kubetest2-kops supports boskos for AWS accounts (kubernetes/kops#15542) and it supports creating ephemeral s3 buckets (kubernetes/kops#16880), then it wont matter which AWS account these jobs run in. Until then these jobs can share the kops AWS account.

/cc @dims @ameukam

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims November 20, 2024 01:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 20, 2024
@dims
Copy link
Member

dims commented Nov 20, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a63dc9c into kubernetes:master Nov 20, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rifelpet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-periodics-conformance.yaml using file config/jobs/kubernetes/kops/kops-periodics-conformance.yaml
  • key kops-periodics-distros.yaml using file config/jobs/kubernetes/kops/kops-periodics-distros.yaml
  • key kops-periodics-grid.yaml using file config/jobs/kubernetes/kops/kops-periodics-grid.yaml
  • key kops-periodics-misc2.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc2.yaml
  • key kops-periodics-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-periodics-network-plugins.yaml
  • key kops-periodics-pipeline.yaml using file config/jobs/kubernetes/kops/kops-periodics-pipeline.yaml
  • key kops-periodics-versions.yaml using file config/jobs/kubernetes/kops/kops-periodics-versions.yaml
  • key kops-presubmits-distros.yaml using file config/jobs/kubernetes/kops/kops-presubmits-distros.yaml
  • key kops-presubmits-e2e.yaml using file config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml
  • key kops-presubmits-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-presubmits-network-plugins.yaml
  • key kops-presubmits-scale.yaml using file config/jobs/kubernetes/kops/kops-presubmits-scale.yaml

In response to this:

Fixes kubernetes/kops#16938
(hopefully)

Those jobs are failing with this error:

Error: error building complete spec: failed to get bucket details for "s3://k8s-kops-ci-prow/discovery/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-canary.test-cncf-aws.k8s.io": Could not retrieve location for AWS bucket k8s-kops-ci-prow

We've seen this happen when the job is running with a different AWS account than the bucket's account.


According to #29722 (comment) the eks-prow-build-cluster is for jobs "that do not depend on external cloud assets"

These kubtest2-kops jobs depend on an existing S3 bucket for kops to function properly, so we'll move these jobs to the same prow cluster that other kops jobs use so that they share the same AWS account.

Eventually when kubetest2-kops supports boskos for AWS accounts (kubernetes/kops#15542) and it supports creating ephemeral s3 buckets (kubernetes/kops#16880), then it wont matter which AWS account these jobs run in. Until then these jobs can share the kops AWS account.

/cc @dims @ameukam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants