-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kubetest2-kops k/k conformance tests to kops prow #33820
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rifelpet: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes kubernetes/kops#16938
(hopefully)
Those jobs are failing with this error:
Error: error building complete spec: failed to get bucket details for "s3://k8s-kops-ci-prow/discovery/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-canary.test-cncf-aws.k8s.io": Could not retrieve location for AWS bucket k8s-kops-ci-prow
We've seen this happen when the job is running with a different AWS account than the bucket's account.
According to #29722 (comment) the
eks-prow-build-cluster
is for jobs "that do not depend on external cloud assets"These kubtest2-kops jobs depend on an existing S3 bucket for kops to function properly, so we'll move these jobs to the same prow cluster that other kops jobs use so that they share the same AWS account.
Eventually when kubetest2-kops supports boskos for AWS accounts (kubernetes/kops#15542) and it supports creating ephemeral s3 buckets (kubernetes/kops#16880), then it wont matter which AWS account these jobs run in. Until then these jobs can share the kops AWS account.
/cc @dims @ameukam