-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sig-node tests failing with dropping NodeFeature #34171
Open
kannon92
wants to merge
5
commits into
kubernetes:master
Choose a base branch
from
kannon92:fall-node-feature-part-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Jan 17, 2025
k8s-ci-robot
added
area/config
Issues or PRs related to code in /config
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
area/jobs
sig/node
Categorizes an issue or PR as relevant to SIG Node.
labels
Jan 17, 2025
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Jan 17, 2025
/hold still have a few more fixes. |
k8s-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Jan 17, 2025
kannon92
force-pushed
the
fall-node-feature-part-2
branch
from
January 17, 2025 18:52
201db12
to
66b73a4
Compare
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/config
Issues or PRs related to code in /config
area/jobs
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.