support jq for mac in bigquery_test #4856
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
the
approved
|
/area bazel |
|
@BenTheElder: What do you do when a blonde throws a grenade at you? Pull the pin and throw it back. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metrics/BUILD
Outdated
| @@ -13,17 +13,38 @@ filegroup( | |||
| tags = ["automanaged"], | |||
| ) | |||
|
|
|||
| config_setting( | |||
There was a problem hiding this comment.
is it possible to put these in the WORKSPACE instead and then use the correct URL depending on the config setting?
There was a problem hiding this comment.
These suggest not but I'll verify:
bazelbuild/bazel#1482
bazelbuild/bazel#1485
There was a problem hiding this comment.
Yeah I get an error containing config_setting cannot be in the WORKSPACE file
At least the jq OSX binary is only 635kb.
There was a problem hiding this comment.
yeah, it looks like the only way to do this is to create a repository_rule, which is unfortunate.
that's probably generalizable and reusable, though I don't know if anyone has done that yet - seems like everyone rolls their own.
|
fixes #4850 |
metrics/BUILD
Outdated
| }), | ||
| data = select({ | ||
| ":k8": [ | ||
| ":all-srcs", |
There was a problem hiding this comment.
factor ":all-srcs" out of the select.
also, this should really be glob(["configs/*"]) rather than ":all-srcs".
There was a problem hiding this comment.
done, had to also include README.md. I'm not sure if the way I wrote it is idiomatic or not.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ixdy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
agh travis! reminder to finish #1342 |
This works but it's not necessarily ideal and test-infra Bazel usage on macOS still really only works from Planter for now 🤷♂️