Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable batch on test-infra-bazel-canary to verify that it fails agai… #5261

Merged
merged 1 commit into from
Oct 30, 2017
Merged

disable batch on test-infra-bazel-canary to verify that it fails agai… #5261

merged 1 commit into from
Oct 30, 2017

Conversation

BenTheElder
Copy link
Member

…n without it

/area jobs
/area bazel

@k8s-ci-robot k8s-ci-robot added area/jobs area/bazel size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2017
@BenTheElder
Copy link
Member Author

This has been pretty heavily tested successfully with it, let's flip it back off and verify that it begins failing again so we can be certain. We should get this fixed upstream if so.

@BenTheElder
Copy link
Member Author

I'd also like to be more confident that this is the solution because if so we can probably safely flip k/k over to 0.7 with --batch on. (third time's the charm! 🤞)

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder BenTheElder merged commit af5fb6c into kubernetes:master Oct 30, 2017
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

…n without it

/area jobs
/area bazel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member Author

(manual merge because I got tired of waiting for travis to run, #1342)

@BenTheElder BenTheElder deleted the no-birdie-batch branch October 30, 2017 23:19
@BenTheElder
Copy link
Member Author

It took three attempts but sure enough it fails without --batch: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/5137/pull-test-infra-bazel-canary/45/

@BenTheElder
Copy link
Member Author

cc @ixdy, looks like --batch is definitely the workable mitigation for now.

@BenTheElder BenTheElder mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kanarynetes 🐦 lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @krzyzacy @k8s-github-robot @k8s-ci-robot