Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎡 Remove k8s.io/kubernetes dependency #5311

Closed

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Nov 2, 2017

We don't need to vendor k8s.io/kubernetes anymore as the package we use have been split up

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cblecker
We suggest the following additional approvers: apelisse, spxtr

Assign the PR to them by writing /assign @apelisse @spxtr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2017
@k8s-ci-robot
Copy link
Contributor

@cblecker: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-test-infra-bazel 87583b5 link /test pull-test-infra-bazel
pull-test-infra-verify-govet 87583b5 link /test pull-test-infra-verify-govet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker
Copy link
Member Author

cblecker commented Nov 2, 2017

This isn't going to be easy to pull out into it's own PR. Collapsing into #5301

@cblecker cblecker closed this Nov 2, 2017
@cblecker cblecker deleted the remove-kubernetes-dependency branch November 2, 2017 02:41
@0xmichalis
Copy link
Contributor

Can you open a separate issue instead of doing this in #5301?

@cblecker cblecker restored the remove-kubernetes-dependency branch November 2, 2017 17:12
@cblecker
Copy link
Member Author

cblecker commented Nov 2, 2017

@Kargakis Yes, I ended up having to pull it from #5301 just because there was some extra bazel funkiness. Will reopen this once #5301 merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants