-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the prow config for multicluster test job #5438
Conversation
@nikhiljindal I need to make the config test for the cache SSD smarter (ref #5436) to allow you to remove the port it seems, if you put the port back for now we can get the other fix in and I can fix the port in a follow up. |
prow/config.yaml
Outdated
@@ -176,9 +176,6 @@ presubmits: | |||
readOnly: true | |||
- name: cache-ssd | |||
mountPath: /root/.cache | |||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that we have a naive config test that forces this port on any job with the cache-ssd mounted. I'll have to fix the test... 😞
33103ec
to
d39209d
Compare
Removed cache-ssd mount to resolve error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, nikhiljindal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Will revisit caching #5436 |
As discussed with @BenTheElder, we probably need the cache so need to add the cache mount back and pass "--git-cache=/root/.cache/git" as args. |
@nikhiljindal: I updated Prow config for you! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(manual merge because it seems travis wouldn't mark green on github despite being long green on travis... #1342) |
Fixing the prow config for multicluster test job as per comments in #5373
cc @krzyzacy @BenTheElder @G-Harmon