Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the prow config for multicluster test job #5438

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

nikhiljindal
Copy link
Contributor

Fixing the prow config for multicluster test job as per comments in #5373

cc @krzyzacy @BenTheElder @G-Harmon

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2017
@BenTheElder
Copy link
Member

@nikhiljindal I need to make the config test for the cache SSD smarter (ref #5436) to allow you to remove the port it seems, if you put the port back for now we can get the other fix in and I can fix the port in a follow up.

prow/config.yaml Outdated
@@ -176,9 +176,6 @@ presubmits:
readOnly: true
- name: cache-ssd
mountPath: /root/.cache
ports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that we have a naive config test that forces this port on any job with the cache-ssd mounted. I'll have to fix the test... 😞

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2017
@nikhiljindal
Copy link
Contributor Author

Removed cache-ssd mount to resolve error Error in presubmit: pull-kubernetes-multicluster-ingress-test: job uses --cache-ssd and so needs to set ports in spec.

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, nikhiljindal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2017
@BenTheElder
Copy link
Member

Will revisit caching #5436

@nikhiljindal
Copy link
Contributor Author

As discussed with @BenTheElder, we probably need the cache so need to add the cache mount back and pass "--git-cache=/root/.cache/git" as args.
Will do that as part of #5436

@BenTheElder BenTheElder merged commit bbf81bb into kubernetes:master Nov 10, 2017
@k8s-ci-robot
Copy link
Contributor

@nikhiljindal: I updated Prow config for you!

In response to this:

Fixing the prow config for multicluster test job as per comments in #5373

cc @krzyzacy @BenTheElder @G-Harmon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

(manual merge because it seems travis wouldn't mark green on github despite being long green on travis... #1342)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants