Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rpm tooling to bazelbuild image #5461

Merged
merged 2 commits into from
Nov 14, 2017
Merged

add rpm tooling to bazelbuild image #5461

merged 2 commits into from
Nov 14, 2017

Conversation

BenTheElder
Copy link
Member

see: #5429
follow-ish up to: #5456

/area bazel
/area images

@k8s-ci-robot k8s-ci-robot added area/bazel area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 11, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2017
@BenTheElder
Copy link
Member Author

TODO: push new images and bump, though there's not much rush until we add actually building RPMs to any of the jobs so this can realistically be a follow up along with support for that.

@ixdy
Copy link
Member

ixdy commented Nov 13, 2017

lgtm

do you want to bump in this PR or a separate one?

@BenTheElder
Copy link
Member Author

do you want to bump in this PR or a separate one?

I'll go ahead and bump.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2017
@BenTheElder
Copy link
Member Author

Grrr, xref #5411.
Fixing the pinned jobs

BenTheElder
BenTheElder commented Nov 13, 2017
View reviewed changes
Copy link
Member Author

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(actually started self review and ixdy LGTM above)

prow/config/config_test.go
@@ -545,8 +545,9 @@ func TestBazelbuildArgs(t *testing.T) {
}
pinnedJobs := map[string]string{
//job: reason for pinning
"pull-test-infra-bazel": "test-infra adopts bazel upgrades first",
"ci-test-infra-bazel": "test-infra adopts bazel upgrades first",
// these frequently need to be pinned...
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to consider updating the presubmit to allow jobs to remain in the pinned whitelist even if they are not current considered pinned, these jobs are repeatedly pinned / unpinned since we dogfood bazel upgrades on test-infra first.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: you cannot LGTM your own PR.

In response to this:

/lgtm
(actually started self review and ixdy LGTM above)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Nov 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 192bec2 into kubernetes:master Nov 14, 2017
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

see: #5429
follow-ish up to: #5456

/area bazel
/area images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the bazelbuild-rpms branch November 14, 2017 01:27
@BenTheElder BenTheElder mentioned this pull request Nov 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@cjwagner cjwagner Awaiting requested review from cjwagner

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @ixdy @k8s-ci-robot