Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PVC Protection in ci-kubernetes-e2e-gci-gce-alpha-features #5864

Conversation

pospispa
Copy link

@pospispa pospispa commented Dec 7, 2017

PVC Protection alpha feature was merged into K8s 1.9 in PRs:

PVC Protection E2E tests are in PR: kubernetes/kubernetes#56931

Adding the PVC Protection tests into the list of Alpha feature tests that are run.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@pospispa
Copy link
Author

pospispa commented Dec 7, 2017

The E2E tests PR is not merged yet so
/hold
/area jobs
/sig testing

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 7, 2017
@BenTheElder
Copy link
Member

/sig gcp

@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Dec 7, 2017
@BenTheElder
Copy link
Member

/approve
@kubernetes/sig-gcp-pr-reviews PTAL, you own this job

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2017
@abgworrall
Copy link
Contributor

as sig-gcp, I've no strong opinions on what should be in alpha testing for GCE. You can take that as an approval :)

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy, pospispa

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [BenTheElder,krzyzacy]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@pospispa
Copy link
Author

The E2E tests PR is merged so
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2017
PVC Protection alpha feature was merged in PRs:
- kubernetes/kubernetes#55824
- kubernetes/kubernetes#55873

PVC Protection E2E tests are in PR: kubernetes/kubernetes#56931

Adding the PVC Protection tests into the list of Alpha feature tests that are run.
@pospispa pospispa force-pushed the 566-postpone-pvc-deletion-if-used-in-a-pod-enable-alpha-feature branch from b883fc5 to 50d2264 Compare December 19, 2017 11:31
@k8s-ci-robot k8s-ci-robot merged commit 15d2a93 into kubernetes:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants